Conversation
Contributor
Author
|
I believe the failed deployment is due to a service degradation affecting Actions, but will confirm when that's resolved. |
Member
|
@jazairi would you mind rebasing to see if the tests and deploy fix themselves as expected? |
Pull Request Test Coverage Report for Build 21637796633Details
💛 - Coveralls |
Why these changes are being introduced: Some records can have many DOIs or PMIDs (as many as 467 in one case). It's probably not helpful for Libkey to assume that the first identifier is the best one. Relevant ticket(s): - https://mitlibraries.atlassian.net/browse/USE-332 How this addresses that need: This adds a guard clause to the DOI and PMID methods that returns nil when multiple identifiers are found. This prevents Libkey from showing an uncertain fulfillment URL. Side effects of this change: Reduction of fulfillment links made available via Libkey.
Contributor
Author
|
@JPrevost All set. |
JPrevost
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
Some records can have many DOIs or PMIDs (as many
as 467 in one case). It's probably not helpful
for Libkey to assume that the first identifier
is the best one.
Relevant ticket(s):
How this addresses that need:
This adds a guard clause to the DOI and PMID
methods that returns nil when multiple identifiers are found. This prevents Libkey from showing an
uncertain fulfillment URL.
Side effects of this change:
Reduction of fulfillment links made available via
Libkey.
Developer
Accessibility
New ENV
Approval beyond code review
Additional context needed to review
E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.
Code Reviewer
Code
added technical debt.
Documentation
(not just this pull request message).
Testing